Re: [PATCH v6 4/9] scsi: Always define blogic_pci_tbl structure
From: Nathan Chancellor
Date: Tue Aug 19 2025 - 03:23:31 EST
Hi Martin,
On Mon, Aug 18, 2025 at 10:04:02PM -0400, Martin K. Petersen wrote:
>
> Alexey,
>
> > The blogic_pci_tbl structure is used by the MODULE_DEVICE_TABLE macro.
> > There is no longer a need to protect it with the MODULE condition,
> > since this no longer causes the compiler to warn about an unused
> > variable.
> >
> > To avoid warnings when -Wunused-const-variable option is used, mark it
> > as __maybe_unused for such configuration.
>
> Applied to 6.18/scsi-staging, thanks!
I think I will need this change to apply patch 7 [1] to kbuild-next
without any issues [2]. If there is little risk of conflict, could I
take it with your Ack? Another option would be getting it into 6.17 as a
fix so that I could back merge Linus's tree and apply the series on top.
I am already going to have to do that for the pinctrl change that Linus
W took [3].
[1]: https://lore.kernel.org/22b36a5807d943a84431298c18b41d093e01c371.1755170493.git.legion@xxxxxxxxxx/
[2]: https://lore.kernel.org/aDWoCU2YrxaCBi42@xxxxxxxxxxx/
[3]: https://lore.kernel.org/CACRpkdZ9oyJ4aJ5Dcp_Dtv5qoiSo+g5cO7Uf4PmHgv_Z423onQ@xxxxxxxxxxxxxx/
Cheers,
Nathan