Re: [PATCH 12/13] arm64: dts: renesas: rzt2h/rzn2h: Enable MicroSD card slot

[Lad, Prabhakar]

Hi Geert,

Thank you for the review.

On Mon, Aug 18, 2025 at 5:03 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Tue, 12 Aug 2025 at 22:04, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Enable MicroSD card slot which is connected to SDHI1 on the RZ/T2H and
> > RZ/N2H EVKs.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
>
> No mmc1 alias?
>
Ouch missed it.

> > @@ -91,6 +103,30 @@ sd0-emmc-ctrl-pins {
> >                                  <RZT2H_PORT_PINMUX(13, 2, 0x29)>; /* SD0_RST# */
> >                 };
> >         };
> > +
> > +#if SD1_MICRO_SD
> > +       sdhi1-pwen-hog {
> > +               gpio-hog;
> > +               gpios = <RZT2H_GPIO(8, 5) GPIO_ACTIVE_HIGH>;
> > +               output-high;
> > +               line-name = "SD1_PWEN";
> > +       };
> > +#endif
> > +
> > +       sdhi1_pins: sd1-group {
> > +               sd1-data-pins {
>
> No need for repeated sd1-prefixes in the subnodes.
>
Ok, I will drop them in v2.

Cheers,
Prabhakar

>
> > +                       pinmux = <RZT2H_PORT_PINMUX(16, 7, 0x29)>, /* SD1_DATA0 */
> > +                                <RZT2H_PORT_PINMUX(17, 0, 0x29)>, /* SD1_DATA1 */
> > +                                <RZT2H_PORT_PINMUX(17, 1, 0x29)>, /* SD1_DATA2 */
> > +                                <RZT2H_PORT_PINMUX(17, 2, 0x29)>; /* SD1_DATA3 */
> > +               };
> > +
> > +               sd1-ctrl-pins {
> > +                       pinmux = <RZT2H_PORT_PINMUX(16, 5, 0x29)>, /* SD1_CLK */
> > +                                <RZT2H_PORT_PINMUX(16, 6, 0x29)>, /* SD1_CMD */
> > +                                <RZT2H_PORT_PINMUX(17, 4, 0x29)>; /* SD1_CD */
> > +               };
> > +       };
> >  };
> >
> >  &sci0 {
>
> The rest LGTM.
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds