Re: [PATCH v1 1/2] mfd: mt6397: Add new bit definitions for RTC_BBPU register
From: Krzysztof Kozlowski
Date: Tue Aug 19 2025 - 04:16:21 EST
On 19/08/2025 09:54, Shunxi Zhang (章顺喜) wrote:
>>> #define RTC_BBPU 0x0000
>>> +#define RTC_BBPU_PWREN BIT(0)
>>> +#define RTC_BBPU_CLR BIT(1)
>>> +#define RTC_BBPU_RESET_AL BIT(3)
>>> #define RTC_BBPU_CBUSY BIT(6)
>>> -#define RTC_BBPU_KEY (0x43 << 8)
>>> +#define RTC_BBPU_KEY (0x43 << 8)
>>
>>
>> Why?
>>
>>
>>
>> Best regards,
>> Krzysztof
>
> Dear sir,
> The MT6397 is an integration of several ICs and does not have a
> separate IC specification. I will check the relevant IC datasheets
> again. I will remove the useless define in next version.
I understand nothing from this reply. I do not see it related to my
questions at all. Do you want to say that you change indentation,
because MT6397 is integration? That makes absolutely NO SENSE!
Best regards,
Krzysztof