Re: [PATCH 10/13] spi: spi-fsl-lpspi: Add compatible for S32G
From: James Clark
Date: Tue Aug 19 2025 - 04:23:17 EST
On 18/08/2025 4:18 pm, Mark Brown wrote:
On Mon, Aug 18, 2025 at 03:31:08PM +0100, James Clark wrote:
On 14/08/2025 7:25 pm, Frank Li wrote:
binding doc should first patch. Create new patch serial for add S32G
support only.
I'm not sure putting the binding doc commit first would be right? That would
imply it was a valid binding before it really was because the code change
hasn't been made yet. Practically both are required so it doesn't really
matter which way around they are.
It's the general practice everyone has adopted (though in this case the
bugfix bits might want to go before the bindings, possibly it's also a
bit unusual to do that). An unused binding is more acceptable than an
undocumented one.
Fair enough. I can flip them in the next version.