RE: [PATCH v7 4/6] arm64: dts: renesas: r9a09g047: Add #address-cells property in sys node

[John Madieu]

Hi Geert,

Thanks for your review!

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Tuesday, August 19, 2025 9:44 AM
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH v7 4/6] arm64: dts: renesas: r9a09g047: Add #address-
> cells property in sys node
> 
> Hi John,
> 
> On Mon, 18 Aug 2025 at 18:29, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> wrote:
> > A couple of registers of the system controller (sys) are shared with
> > the TSU device. Add #address-cells property to sys node to allow
> > proper parsing a access to these registers from the TSU driver.
> >
> > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> > @@ -278,6 +278,7 @@ sys: system-controller@10430000 {
> >                         reg = <0 0x10430000 0 0x10000>;
> >                         clocks = <&cpg CPG_CORE R9A09G047_SYS_0_PCLK>;
> >                         resets = <&cpg 0x30>;
> > +                       #address-cells = <1>;
> 
> Iff you need this, you need to update the DT bindings first, as reported by
> Rob's bot.
> 
> However, looking at Claudiu's USB series [1], I think you can do without,
> by calling of_parse_phandle_with_fixed_args() instead of
> of_parse_phandle_with_args() in the driver.
> 
> >                 };

Indeed, I'll use the fixed_args() option and drop this patch
in v8.

> >
> >                 xspi: spi@11030000 {
> 
> [1] "[PATCH v5 0/7] Add initial USB support for the Renesas RZ/G3S SoC"
>     https://lore.kernel.org/20250819054212.486426-1-
> claudiu.beznea.uj@xxxxxxxxxxxxxx
> 
> Gr{oetje,eeting}s,

Regards,
John

> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds