Re: [PATCH v4 3/6] arm64: dts: qcom: qcs615: add ethernet node
From: Yijie Yang
Date: Tue Aug 19 2025 - 05:06:29 EST
On 2025-08-19 15:15, Krzysztof Kozlowski wrote:
On 19/08/2025 08:51, Yijie Yang wrote:
On 2025-08-19 14:44, Krzysztof Kozlowski wrote:
On 19/08/2025 08:35, YijieYang wrote:
From: Yijie Yang <quic_yijiyang@xxxxxxxxxxx>
Add an ethernet controller node for QCS615 SoC to enable ethernet
functionality.
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Signed-off-by: Yijie Yang <quic_yijiyang@xxxxxxxxxxx>
---
Why do you mix up DTS and net-next patches? This only makes difficult to
apply it, for no benefits.
The DTS changes and driver code modifications work together to achieve a
single purpose, so I included them in one patch series. Should I
consider splitting them into two separate series?
Of course yes. You are just making difficult to apply this. Patches are
completely independent and even your internal guideline asks to NOT
combine independent patches.
The challenge with splitting this series lies in the fact that it
attempts to reverse the incorrect semantics of phy-mode in both the
driver code and the device tree. Selecting only part of the series would
break Ethernet functionality on both boards.
As you can see, I’ve CC’d noautosel to prevent this issue. Given the
circumstances, I’m wondering if it would be acceptable to leave the
series as-is?
Best regards,
Krzysztof
--
Best Regards,
Yijie