Re: [PATCH v2 3/3] usb: usb251xb: support usage case without I2C control

From: Krzysztof Kozlowski
Date: Tue Aug 19 2025 - 05:27:56 EST


On Tue, Aug 19, 2025 at 08:22:17AM +0800, Jisheng Zhang wrote:
> +
> +static DEFINE_SIMPLE_DEV_PM_OPS(usb251xb_plat_pm_ops, usb251xb_plat_suspend, usb251xb_plat_resume);
> +
> +static struct platform_driver usb251xb_plat_driver = {
> + .driver = {
> + .name = DRIVER_NAME,
> + .of_match_table = of_match_ptr(usb251xb_of_match),

No, drop of_match_ptr. This is neither correct nor helpful.
Look at existing code.

Best regards,
Krzysztof