Re: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate

From: Linus Walleij
Date: Tue Aug 19 2025 - 08:59:28 EST


On Mon, Aug 18, 2025 at 6:41 AM Fange Zhang
<fange.zhang@xxxxxxxxxxxxxxxx> wrote:

> Set PINCTRL_SX150X config option as a tristate and add
> MODULE_DEVICE_TABLE()/MODULE_LICENSE() to export appropriate information.
>
> Signed-off-by: Fange Zhang <fange.zhang@xxxxxxxxxxxxxxxx>

Fair enough!

This patch 1/2 applied to the pinctrl tree.

Please funnel patch 2/2 through the SoC tree.

> subsys_initcall(sx150x_init

I seriously wonder about this. It feels like this driver should
be a pure module_init() device. But other users may disagree.

Yours,
Linus Walleij