Re: [PATCH] lib/vsprintf: remove redundant header files

From: Liao Yuanhong
Date: Tue Aug 19 2025 - 10:22:36 EST



On 8/19/2025 9:37 PM, Miguel Ojeda wrote:
[You don't often get email from miguel.ojeda.sandonis@xxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

On Tue, Aug 19, 2025 at 3:13 PM Liao Yuanhong <liaoyuanhong@xxxxxxxx> wrote:
The header file <linux/stdarg.h> is already included on line 6. Remove the
redundant include.

Fixes: 0dec7201788b9 ("sprintf.h requires stdarg.h")
I don't think this fixes that commit -- `stdarg.h` was not there back then.

Instead, this commit

be06b53d3af0 ("lib/vsprintf: include stdarg.h from sprintf.h to
provide va_list")

also added the line, and I assume Stephen only needs to drop one of
the lines in this merge resolution next time:

3f413b9a3770 ("Merge branch 'next' of
https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git";)

Thanks!

Cheers,
Miguel

Thank you for your feedback. Do I need to submit the v2 version without fixes?


Regards,

Liao