Re: [PATCH net-next v3 04/23] net: use zero value to restore rx_buf_len to default

[Pavel Begunkov]

On 8/19/25 01:07, Mina Almasry wrote:
> On Mon, Aug 18, 2025 at 6:56 AM Pavel Begunkov <asml.silence@xxxxxxxxx> wrote:
> > From: Jakub Kicinski <kuba@xxxxxxxxxx>
> >
> > Distinguish between rx_buf_len being driver default vs user config.
> > Use 0 as a special value meaning "unset" or "restore driver default".
> > This will be necessary later on to configure it per-queue, but
> > the ability to restore defaults may be useful in itself.
> >
> > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> > Signed-off-by: Pavel Begunkov <asml.silence@xxxxxxxxx>
>
> I wonder if it should be extended to the other driver using
> rx_buf_len, hns3. For that, I think the default buf size would be
> HNS3_DEFAULT_RX_BUF_LEN.

I'd rather avoid growing the series even more, let's follow up on
that in a separate patch on top, that should be just fine. And
thanks for the review

> Other than that, seems fine to me,
>
> Reviewed-by: Mina Almasry <almasrymina@xxxxxxxxxx>

With the said above, do you want me to retain the review tag?

--
Pavel Begunkov