Re: [PATCH v2 1/3] dt-bindings: interconnect: document the RPMh Network-On-Chip interconnect in Glymur SoC

[Dmitry Baryshkov]

On Thu, Aug 14, 2025 at 02:54:19PM +0000, Raviteja Laggyshetty wrote:
> Document the RPMh Network-On-Chip Interconnect in Glymur platform.
> 
> Co-developed-by: Odelu Kukatla <odelu.kukatla@xxxxxxxxxxxxxxxx>
> Signed-off-by: Odelu Kukatla <odelu.kukatla@xxxxxxxxxxxxxxxx>
> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@xxxxxxxxxxxxxxxx>
> ---
>  .../bindings/interconnect/qcom,glymur-rpmh.yaml    | 172 +++++++++++++++++
>  .../dt-bindings/interconnect/qcom,glymur-rpmh.h    | 205 +++++++++++++++++++++
>  2 files changed, 377 insertions(+)

> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/qcom,glymur-gcc.h>

Please drop this header and use ephemeral clocks in the devices below.
We don't need to point out particular GCC clocks, using
<&gcc_foo_bar_baz> is more than enough.

> +    clk_virt: interconnect-0 {
> +      compatible = "qcom,glymur-clk-virt";
> +      #interconnect-cells = <2>;
> +      qcom,bcm-voters = <&apps_bcm_voter>;
> +    };
> +
> +    aggre1_noc: interconnect@16e0000 {
> +      compatible = "qcom,glymur-aggre1-noc";
> +      reg = <0x016e0000 0x14400>;
> +      #interconnect-cells = <2>;
> +      qcom,bcm-voters = <&apps_bcm_voter>;
> +    };
> +
> +    aggre4_noc: interconnect@1740000 {
> +      compatible = "qcom,glymur-aggre4-noc";
> +      reg = <0x01740000 0x14400>;
> +      #interconnect-cells = <2>;
> +      qcom,bcm-voters = <&apps_bcm_voter>;
> +      clocks = <&gcc GCC_AGGRE_USB3_PRIM_AXI_CLK>,
> +               <&gcc GCC_AGGRE_USB3_SEC_AXI_CLK>,
> +               <&gcc GCC_AGGRE_USB4_0_AXI_CLK>,
> +               <&gcc GCC_AGGRE_USB4_1_AXI_CLK>;
> +    };

-- 
With best wishes
Dmitry