Re: [PATCH] delayacct/sched: add SOFTIRQ delay
From: kernel test robot
Date: Tue Aug 19 2025 - 20:29:42 EST
Hi Tio,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.17-rc2 next-20250819]
[cannot apply to tip/sched/core peterz-queue/sched/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Tio-Zhang/delayacct-sched-add-SOFTIRQ-delay/20250819-173756
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20250819092739.GA31177%40didi-ThinkCentre-M930t-N000
patch subject: [PATCH] delayacct/sched: add SOFTIRQ delay
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20250820/202508200857.4KUgmreB-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250820/202508200857.4KUgmreB-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508200857.4KUgmreB-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
In file included from kernel/sched/build_utility.c:93:
kernel/sched/psi.c: In function 'psi_account_irqtime':
>> kernel/sched/psi.c:1024:15: error: too few arguments to function 'irq_time_read'
1024 | irq = irq_time_read(cpu);
| ^~~~~~~~~~~~~
In file included from kernel/sched/build_utility.c:52:
kernel/sched/sched.h:3159:19: note: declared here
3159 | static inline u64 irq_time_read(int cpu, u64 *total_soft)
| ^~~~~~~~~~~~~
vim +/irq_time_read +1024 kernel/sched/psi.c
eb414681d5a07d Johannes Weiner 2018-10-26 1004
52b1364ba0b105 Chengming Zhou 2022-08-26 1005 #ifdef CONFIG_IRQ_TIME_ACCOUNTING
ddae0ca2a8fe12 John Stultz 2024-06-18 1006 void psi_account_irqtime(struct rq *rq, struct task_struct *curr, struct task_struct *prev)
52b1364ba0b105 Chengming Zhou 2022-08-26 1007 {
ddae0ca2a8fe12 John Stultz 2024-06-18 1008 int cpu = task_cpu(curr);
52b1364ba0b105 Chengming Zhou 2022-08-26 1009 struct psi_group_cpu *groupc;
ddae0ca2a8fe12 John Stultz 2024-06-18 1010 s64 delta;
3840cbe24cf060 Johannes Weiner 2024-10-03 1011 u64 irq;
570c8efd5eb79c Peter Zijlstra 2025-05-23 1012 u64 now;
52b1364ba0b105 Chengming Zhou 2022-08-26 1013
a6fd16148fdd7e Yafang Shao 2025-01-03 1014 if (static_branch_likely(&psi_disabled) || !irqtime_enabled())
0c2924079f5a83 Haifeng Xu 2023-09-26 1015 return;
0c2924079f5a83 Haifeng Xu 2023-09-26 1016
ddae0ca2a8fe12 John Stultz 2024-06-18 1017 if (!curr->pid)
ddae0ca2a8fe12 John Stultz 2024-06-18 1018 return;
ddae0ca2a8fe12 John Stultz 2024-06-18 1019
ddae0ca2a8fe12 John Stultz 2024-06-18 1020 lockdep_assert_rq_held(rq);
570c8efd5eb79c Peter Zijlstra 2025-05-23 1021 if (prev && task_psi_group(prev) == task_psi_group(curr))
52b1364ba0b105 Chengming Zhou 2022-08-26 1022 return;
52b1364ba0b105 Chengming Zhou 2022-08-26 1023
ddae0ca2a8fe12 John Stultz 2024-06-18 @1024 irq = irq_time_read(cpu);
ddae0ca2a8fe12 John Stultz 2024-06-18 1025 delta = (s64)(irq - rq->psi_irq_time);
ddae0ca2a8fe12 John Stultz 2024-06-18 1026 if (delta < 0)
ddae0ca2a8fe12 John Stultz 2024-06-18 1027 return;
ddae0ca2a8fe12 John Stultz 2024-06-18 1028 rq->psi_irq_time = irq;
52b1364ba0b105 Chengming Zhou 2022-08-26 1029
570c8efd5eb79c Peter Zijlstra 2025-05-23 1030 psi_write_begin(cpu);
570c8efd5eb79c Peter Zijlstra 2025-05-23 1031 now = cpu_clock(cpu);
3840cbe24cf060 Johannes Weiner 2024-10-03 1032
570c8efd5eb79c Peter Zijlstra 2025-05-23 1033 for_each_group(group, task_psi_group(curr)) {
34f26a15611afb Chengming Zhou 2022-09-07 1034 if (!group->enabled)
34f26a15611afb Chengming Zhou 2022-09-07 1035 continue;
34f26a15611afb Chengming Zhou 2022-09-07 1036
52b1364ba0b105 Chengming Zhou 2022-08-26 1037 groupc = per_cpu_ptr(group->pcpu, cpu);
52b1364ba0b105 Chengming Zhou 2022-08-26 1038
52b1364ba0b105 Chengming Zhou 2022-08-26 1039 record_times(groupc, now);
52b1364ba0b105 Chengming Zhou 2022-08-26 1040 groupc->times[PSI_IRQ_FULL] += delta;
52b1364ba0b105 Chengming Zhou 2022-08-26 1041
65457b74aa9437 Domenico Cerasuolo 2023-03-30 1042 if (group->rtpoll_states & (1 << PSI_IRQ_FULL))
65457b74aa9437 Domenico Cerasuolo 2023-03-30 1043 psi_schedule_rtpoll_work(group, 1, false);
570c8efd5eb79c Peter Zijlstra 2025-05-23 1044 }
570c8efd5eb79c Peter Zijlstra 2025-05-23 1045 psi_write_end(cpu);
52b1364ba0b105 Chengming Zhou 2022-08-26 1046 }
fd3db705f7496c Ingo Molnar 2025-05-28 1047 #endif /* CONFIG_IRQ_TIME_ACCOUNTING */
52b1364ba0b105 Chengming Zhou 2022-08-26 1048
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki