Re: [PATCH v7 0/7] Add SEV-SNP CipherTextHiding feature support
From: Kalra, Ashish
Date: Tue Aug 19 2025 - 21:17:30 EST
Hello Sean,
On 8/19/2025 7:05 PM, Sean Christopherson wrote:
> On Tue, Aug 19, 2025, Borislav Petkov wrote:
>> On Mon, Aug 18, 2025 at 02:38:38PM -0500, Kim Phillips wrote:
>>> I have pending comments on patch 7:
>>
>> If you're so hell-bent on doing your improvements on-top or aside of them, you
>> take his patch, add your stuff ontop or rewrite it, test it and then you send
>> it out and say why yours is better.
>>
>> Then the maintainer decides.
>>
>> There's no need to debate ad absurdum - you simply offer your idea and the
>> maintainer decides which one is better. As it has always been done.
>
> Or, the maintainer says "huh!?" and goes with option C.
>
> Why take a string in the first place? Just use '-1' as "max/auto".
It's just that there was general feedback to use a string like "max".
But as a maintainer if you are suggesting to use '-1' as "max/auto", i can do that.
Thanks,
Ashish