Re: [PATCH v4] mm/zswap: store <PAGE_SIZE compression failed page as-is
From: Herbert Xu
Date: Wed Aug 20 2025 - 01:10:57 EST
On Tue, Aug 19, 2025 at 10:07:57PM -0700, Chris Li wrote:
>
> But if that error case can never happen, we should convert the crypto
> compression from returning error number to bool instead. It does not
> make sense to return a free form error code and also demand the caller
> does not check on it. If you insist that the caller should check
> return value like a boolean, just let the API return a boolean.
No we need the error value for other things, such as asynchronous
return -EINPROGRESS.
Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt