Re: [PATCH] panic: Clean up message about deprecated 'panic_print' parameter

[Lance Yang]

On 2025/8/20 09:56, Lance Yang wrote:
> On 2025/8/20 09:54, Lance Yang wrote:
> > On 2025/8/20 09:31, kernel test robot wrote:
> > > Hi Petr,
> > >
> > > kernel test robot noticed the following build errors:
> > >
> > >
> > >
> > > url:    https://github.com/intel-lab-lkp/linux/commits/ 
> > > UPDATE-20250819-180717/Feng-Tang/lib-sys_info-handle-sys_info_mask-0- 
> > > case/20250815-152131
> > > base:   the 3th patch of https://lore.kernel.org/ 
> > > r/20250815071428.98041-4-feng.tang%40linux.alibaba.com
> > > patch link:    https://lore.kernel.org/r/ 
> > > aKRJKZHgcxyNF3y7%40pathway.suse.cz
> > > patch subject: [PATCH] panic: Clean up message about deprecated 
> > > 'panic_print' parameter
> > > config: i386-buildonly-randconfig-004-20250820 (https:// 
> > > download.01.org/0day-ci/archive/20250820/202508200907.PsZ3geub- 
> > > lkp@xxxxxxxxx/config)
> > > compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 
> > > 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/ 
> > > archive/20250820/202508200907.PsZ3geub-lkp@xxxxxxxxx/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new 
> > > version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > > | Closes: https://lore.kernel.org/oe-kbuild- 
> > > all/202508200907.PsZ3geub- lkp@xxxxxxxxx/
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > > > kernel/panic.c:952:2: error: call to undeclared function 
> > > > > 'panic_print_deprecated'; ISO C99 and later do not support implicit 
> > > > > function declarations [-Wimplicit-function-declaration]
> > >       952 |         panic_print_deprecated();
> > >           |         ^
> > >     kernel/panic.c:958:2: error: call to undeclared function 
> > > 'panic_print_deprecated'; ISO C99 and later do not support implicit 
> > > function declarations [-Wimplicit-function-declaration]
> > >       958 |         panic_print_deprecated();
> > >           |         ^
> > >     2 errors generated.
> >
> >
> > Oops, panic_print_deprecated() is defined within the #ifdef
> > CONFIG_PROC_SYSCTL block, but it's also called from panic_print_set()
>
> Correction:
>
> CONFIG_SYSCTL block - sorry ;(
>
> > and panic_print_get(), which are outside of that block.
> >
> > So, we need to move the definition out of the block to a common
> > scope where all its callers can see it. @Petr wdyt?

If Petr is cool, @Andrew could you squash the following?

---
Subject: [PATCH 1/1] fixup: panic: clean up message about deprecated
 'panic_print' parameter

From: Lance Yang <lance.yang@xxxxxxxxx>

Moving the definition out of the CONFIG_SYSCTL block to a common scope
where all its callers can see it.

Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: 
https://lore.kernel.org/oe-kbuild-all/202508200907.PsZ3geub-lkp@xxxxxxxxx/
Signed-off-by: Lance Yang <lance.yang@xxxxxxxxx>
---
 kernel/panic.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index d3907fd95d72..24bca263f896 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -77,6 +77,11 @@ ATOMIC_NOTIFIER_HEAD(panic_notifier_list);

 EXPORT_SYMBOL(panic_notifier_list);

+static void panic_print_deprecated(void)
+{
+	pr_info_once("Kernel: The 'panic_print' parameter is now deprecated. 
Please use 'panic_sys_info' and 'panic_console_replay' instead.\n");
+}
+
 #ifdef CONFIG_SYSCTL

 /*
@@ -122,11 +127,6 @@ static int proc_taint(const struct ctl_table 
*table, int write,
 	return err;
 }

-static void panic_print_deprecated(void)
-{
-	pr_info_once("Kernel: The 'panic_print' parameter is now deprecated. 
Please use 'panic_sys_info' and 'panic_console_replay' instead.\n");
-}
-
 static int sysctl_panic_print_handler(const struct ctl_table *table, 
int write,
 			   void *buffer, size_t *lenp, loff_t *ppos)
 {
--
2.49.0