Re: [PATCH] pds_fwctl: Remove the use of dev_err_probe()

[Jonathan Cameron]

On Wed, 20 Aug 2025 20:40:11 +0800
Liao Yuanhong <liaoyuanhong@xxxxxxxx> wrote:

> Logging messages that show some type of "out of memory" error are generally
> unnecessary as there is a generic message and a stack dump done by the
> memory subsystem. These messages generally increase kernel size without
> much added value[1].
> 
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
> remove the useless call to dev_err_probe(), and just return the value
> instead.
> 
> [1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@xxxxxxxx>
Not high priority but I'm fine with these in general.

Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>