Re: [PATCH v4 1/2] iio: magnetometer: add support for Infineon TLV493D 3D Magentic sensor

[Andy Shevchenko]

On Wed, Aug 20, 2025 at 10:16:29AM +0530, Dixit Parmar wrote:
> On Sat, Aug 16, 2025 at 02:04:48PM +0100, Jonathan Cameron wrote:

...

> > > +	TLV493D_AXIS_X,
> > > +	TLV493D_AXIS_Y,
> > > +	TLV493D_AXIS_Z,
> > > +	TLV493D_TEMPERATURE
> > As below.
> > 
> > > +};
> > > +
> > > +enum tlv493d_op_mode {
> > > +	TLV493D_OP_MODE_POWERDOWN,
> > > +	TLV493D_OP_MODE_FAST,
> > > +	TLV493D_OP_MODE_LOWPOWER,
> > > +	TLV493D_OP_MODE_ULTRA_LOWPOWER,
> > > +	TLV493D_OP_MODE_MASTERCONTROLLED
> > This is not a terminating entry, so would typically have a trailing comma.
> Isn't the last entry in the enum list is termintating entry and it should
> not have trailing comma?

No, it's not semantically. (Yes, it's terminating the list syntactically)

> > > +};

-- 
With Best Regards,
Andy Shevchenko