Re: [PATCH net] net: pse-pd: pd692x0: Fix power budget leak in manager setup error path

[Markus Elfring]

…
> +++ b/drivers/net/pse-pd/pd692x0.c
…
> @@ -1185,31 +1217,27 @@ static int pd692x0_setup_pi_matrix(struct pse_controller_dev *pcdev)
…
> +	pd692x0_of_put_managers(priv, manager, nmanagers);
> +	return 0;

How do you think about to apply the following code variant?

	ret = 0;
	goto put_managers;


>  
> -		for (j = 0; j < manager[i].nports; j++)
> -			of_node_put(manager[i].port_node[j]);
> -		of_node_put(manager[i].node);
> -	}
> +err_managers_req_pw:

free_pw_budget:


> +	pd692x0_managers_free_pw_budget(priv);
> +err_of_managers:

put_managers:


> +	pd692x0_of_put_managers(priv, manager, nmanagers);
>  	return ret;
>  }
…


Regards,
Markus