Re: [PATCH v4 2/3] virtio-spi: Add virtio-spi.h

[Andy Shevchenko]

On Wed, Aug 20, 2025 at 04:49:43PM +0800, Haixu Cui wrote:
> Add virtio-spi.h header for virtio SPI.

...

> +/**

This is kernel-doc comment...

> + * struct virtio_spi_config - All config fields are read-only for the
> + * Virtio SPI driver

> + */

...

> +/*
> + * @chip_select_id: chipselect index the SPI transfer used.
> + *

But this one (besides having tons of unneeded blank lines) is not. Why is this
inconsistency?

> + */

...

> +struct spi_transfer_result {
> +#define VIRTIO_SPI_TRANS_OK	0
> +#define VIRTIO_SPI_PARAM_ERR	1
> +#define VIRTIO_SPI_TRANS_ERR	2
> +	__u8 result;
> +};

And this data type has no doc at all...


-- 
With Best Regards,
Andy Shevchenko