Re: [PATCH] mmc: host: renesas_sdhi: Replace magic number '0xff' in renesas_sdhi_set_clock()

From: Ulf Hansson
Date: Wed Aug 20 2025 - 12:44:21 EST


On Wed, 20 Aug 2025 at 12:48, Biju <biju.das.au@xxxxxxxxx> wrote:
>
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Replace the magic number '0xff' with CLK_CTL_DIV_MASK macro for finding
> actual clock in renesas_sdhi_set_clock().
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe

> ---
> drivers/mmc/host/renesas_sdhi_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index a41291a28e9b..f56fa2cd208d 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -223,7 +223,7 @@ static void renesas_sdhi_set_clock(struct tmio_mmc_host *host,
> }
>
> clock = clk & CLK_CTL_DIV_MASK;
> - if (clock != 0xff)
> + if (clock != CLK_CTL_DIV_MASK)
> host->mmc->actual_clock /= (1 << (ffs(clock) + 1));
>
> sd_ctrl_write16(host, CTL_SD_CARD_CLK_CTL, clock);
> --
> 2.43.0
>