Re: [PATCH] media: atomisp: use kmalloc_array() for array space allocation

From: Qianfeng Rong
Date: Wed Aug 20 2025 - 23:29:49 EST



在 2025/8/20 23:05, Andy Shevchenko 写道:
On Sun, Aug 17, 2025 at 05:29:39PM +0800, Qianfeng Rong wrote:
Replace kmalloc(count * sizeof) with kmalloc_array() for safer memory
allocation and overflow prevention.
...

- descr->in_info = kmalloc(descr->num_stage *
- sizeof(struct ia_css_frame_info),
- GFP_KERNEL);
+ descr->in_info = kmalloc_array(descr->num_stage,
+ sizeof(struct ia_css_frame_info),
+ GFP_KERNEL);
At the same time it would be nice to use sizeof(*...) variants instead of using
type-based.
I prefer sizeof(type), but using sizeof(*ptr) here shortens the line and is indeed better.

Best regards,
Qianfeng