Re: [PATCH] lib/crypto: Drop inline from all *_mod_init_arch() functions

From: Eric Biggers
Date: Wed Aug 20 2025 - 23:41:50 EST


On Fri, Aug 15, 2025 at 07:04:57PM -0700, Eric Biggers wrote:
> Drop 'inline' from all the *_mod_init_arch() functions so that the
> compiler will warn about any bugs where they are unused due to not being
> wired up properly. (There are no such bugs currently, so this just
> establishes a more robust convention for the future. Of course, these
> functions also tend to get inlined anyway, regardless of the keyword.)
>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
> lib/crypto/arm/sha1.h | 2 +-
> lib/crypto/arm/sha256.h | 2 +-
> lib/crypto/arm/sha512.h | 2 +-
> lib/crypto/arm64/sha1.h | 2 +-
> lib/crypto/arm64/sha256.h | 2 +-
> lib/crypto/arm64/sha512.h | 2 +-
> lib/crypto/riscv/sha256.h | 2 +-
> lib/crypto/riscv/sha512.h | 2 +-
> lib/crypto/s390/sha1.h | 2 +-
> lib/crypto/s390/sha256.h | 2 +-
> lib/crypto/s390/sha512.h | 2 +-
> lib/crypto/sparc/md5.h | 2 +-
> lib/crypto/sparc/sha1.h | 2 +-
> lib/crypto/sparc/sha256.h | 2 +-
> lib/crypto/sparc/sha512.h | 2 +-
> lib/crypto/x86/sha1.h | 2 +-
> lib/crypto/x86/sha256.h | 2 +-
> lib/crypto/x86/sha512.h | 2 +-
> 18 files changed, 18 insertions(+), 18 deletions(-)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

- Eric