[PATCH v2 2/2] cpufreq: simplify setpolicy/target check in driver verification

[Zihuan Zhang]

Currently the driver verification code uses two separate conditions to
ensure that exactly one of setpolicy or target functions is provided:

    if (!has_setpolicy && !has_target)
        return -EINVAL;
    if (has_setpolicy && has_target)
        return -EINVAL;

This can be simplified into a single condition:

    if (has_setpolicy == has_target)
        return -EINVAL;

which makes the intent clearer and avoids duplicated logic.
No functional changes intended.

Signed-off-by: Zihuan Zhang <zhangzihuan@xxxxxxxxxx>
---
 drivers/cpufreq/cpufreq.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index a067b5447fe8..92633ff2c4f3 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -2908,6 +2908,8 @@ static int cpuhp_cpufreq_offline(unsigned int cpu)
 int cpufreq_register_driver(struct cpufreq_driver *driver_data)
 {
 	unsigned long flags;
+	bool has_setpolicy = driver_data->setpolicy;
+	bool has_target = driver_data->target_index || driver_data->target;
 	int ret;
 
 	if (cpufreq_disabled())
@@ -2921,10 +2923,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
 		return -EPROBE_DEFER;
 
 	if (!driver_data || !driver_data->verify || !driver_data->init ||
-	    !(driver_data->setpolicy || driver_data->target_index ||
-		    driver_data->target) ||
-	     (driver_data->setpolicy && (driver_data->target_index ||
-		    driver_data->target)) ||
+	     (has_setpolicy == has_target) ||
 	     (!driver_data->get_intermediate != !driver_data->target_intermediate) ||
 	     (!driver_data->online != !driver_data->offline) ||
 		 (driver_data->adjust_perf && !driver_data->fast_switch))
-- 
2.25.1