Re: [PATCH] mm: fix KASAN build error due to p*d_populate_kernel()

From: Lorenzo Stoakes
Date: Thu Aug 21 2025 - 07:51:21 EST


On Thu, Aug 21, 2025 at 07:42:06PM +0900, Harry Yoo wrote:
> > > Signed-off-by: Harry Yoo <harry.yoo@xxxxxxxxxx>
> >
> > This looks good, other than the nit below re: a comment, I think when we
> > are doing this kind of thing it's necessary to spell out plainly why
> > exactly we're doing it because it's not obvious at first glance.
>
> Good point, will do:
>
> /*
> * {pgd,p4d}_populate_kernel() are defined as macros to allow
> * compile-time optimization based on the configured page table levels.
> * Without this, linking may fail because callers (e.g., KASAN) may rely
> * on calls to these functions being optimized away when passing symbols
> * that exist only for certain page table levels.
> */

Thanks LGTM!