Re: [PATCH 7/7] iio: temperature: mlx90635: Remove dev_err_probe() if error is -ENOMEM

[Andy Shevchenko]

On Thu, Aug 21, 2025 at 2:47 PM Crt Mori <cmo@xxxxxxxxxxx> wrote:
>
> I am not sure I agree with this. It provides an error message with
> reason and I understand we want as few as possible, but this would be
> a valid remark inside the logs?

How? dev_err_probe() is no-op for ENOMEM.

Also there is an agreement inside the kernel community that ENOMEM
errors need no log, as if it's the case, we have much bigger issues
than that.

> On Thu, 21 Aug 2025 at 10:08, Xichao Zhao <zhao.xichao@xxxxxxxx> wrote:
> >
> > The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> > Therefore, remove the useless call to dev_err_probe(), and just
> > return the value instead.

With all that said, the series is correct and good to go. I don't see
obstacles otherwise.

-- 
With Best Regards,
Andy Shevchenko