[PATCH v3 1/3] staging: media: atomisp: Remove unnecessary forward declaration in gdc.c

From: Adrian Barnaś
Date: Thu Aug 21 2025 - 09:45:28 EST


Get rid of gdc_reg_store() forward declaration because it brings no value.

Signed-off-by: Adrian Barnaś <abarnas@xxxxxxxxxx>
---
.../pci/hive_isp_css_common/host/gdc.c | 24 ++++---------------
1 file changed, 5 insertions(+), 19 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
index 8bb78b4d7c677..bfda3cd13306e 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
@@ -11,13 +11,11 @@

#include "assert_support.h"

-/*
- * Local function declarations
- */
-static inline void gdc_reg_store(
- const gdc_ID_t ID,
- const unsigned int reg,
- const hrt_data value);
+static inline void gdc_reg_store(const gdc_ID_t ID, const unsigned int reg,
+ const hrt_data value)
+{
+ ia_css_device_store_uint32(GDC_BASE[ID] + reg * sizeof(hrt_data), value);
+}

#ifndef __INLINE_GDC__
#include "gdc_private.h"
@@ -92,15 +90,3 @@ int gdc_get_unity(
(void)ID;
return (int)(1UL << HRT_GDC_FRAC_BITS);
}
-
-/*
- * Local function implementations
- */
-static inline void gdc_reg_store(
- const gdc_ID_t ID,
- const unsigned int reg,
- const hrt_data value)
-{
- ia_css_device_store_uint32(GDC_BASE[ID] + reg * sizeof(hrt_data), value);
- return;
-}
--
2.51.0.rc2.233.g662b1ed5c5-goog