Re: [PATCH net-next v2 3/3] net: stmmac: Set CIC bit only for TX queues with COE

[G Thomas, Rohan]

Hi Jakub,

On 8/20/2025 9:26 PM, Jakub Kicinski wrote:
> On Wed, 20 Aug 2025 08:54:46 -0700 Jakub Kicinski wrote:
> > On Wed, 20 Aug 2025 12:44:18 +0530 G Thomas, Rohan wrote:
> > > On 8/20/2025 6:52 AM, Jakub Kicinski wrote:
> > > > Hopefully the slight pointer chasing here doesn't impact performance?
> > > > XDP itself doesn't support checksum so perhaps we could always pass
> > > > false?
> > >
> > > I'm not certain whether some XDP applications might be benefiting from
> > > checksum offloading currently
> >
> > Checksum offload is not supported in real XDP, AFAIK, and in AF_XDP
> > the driver must implement a checksum callback which stmmac does not do.
> > IOW it's not possible to use Tx checksum offload in stmmac today from
> > XDP.
>
> To be clear -- this is just for context. I don't understand the details
> of what the CIC bit controls, so the final decision is up to you.

Currently, in the stmmac driver, even though tmo_request_checksum is not
implemented, checksum offloading is still effectively enabled for AF_XDP
frames, as CIC bit for tx desc are set, which implies checksum
calculation and insertion by hardware for IP packets. So, I'm thinking
it is better to keep it as false only for queues that do not support
COE.

Best Regards,
Rohan