Re: [PATCH net-next v4 7/7] net: devmem: allow binding on rx queues with same DMA devices
From: Jakub Kicinski
Date: Thu Aug 21 2025 - 10:43:02 EST
On Thu, 21 Aug 2025 11:10:57 +0000 Dragos Tatulea wrote:
> > I think we may want to bubble up the Multi-PF thing from the comment to
> > the user. This could be quite confusing to people. How about:
> >
> > "DMA device mismatch between queue %u and %u (multi-PF device?)"
> Sounds good. Do we still need the comment? A similar remark is done in
> the commit message as well.
I think the comment can go away with the better user-facing message.
The commit msg LGTM as is, doesn't count as extra LoC..