Re: [PATCH net-next 03/15] net: phy: aquantia: reorder AQR113C PMD Global Transmit Disable bit clearing with supported_interfaces

[Andrew Lunn]

On Thu, Aug 21, 2025 at 06:20:10PM +0300, Vladimir Oltean wrote:
> Introduced in commit bed90b06b681 ("net: phy: aquantia: clear PMD Global
> Transmit Disable bit during init"), the clearing of MDIO_PMA_TXDIS plus
> the call to aqr107_wait_processor_intensive_op() are only by chance
> placed between aqr107_config_init() and aqr107_fill_interface_modes().
> In other words, aqr107_fill_interface_modes() does not depend in any way
> on these 2 operations.
> 
> I am only 90% sure of that, and I intend to move aqr107_fill_interface_modes()
> to be a part of aqr107_config_init() in the future. So to isolate the
> issue for blame attribution purposes, make these 2 functions adjacent to
> each other again.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew