Re: [PATCH RFC net-next 20/23] net: dsa: lantiq_gswip: add registers specific for MaxLinear GSW1xx

[Sverdlin, Alexander]

Hi Daniel,

On Sat, 2025-08-16 at 20:56 +0100, Daniel Golle wrote:
> Add registers needed for MaxLinear GSW1xx family of dedicated switch
> ICs connected via MDIO or SPI.
> 
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>
> ---
>  drivers/net/dsa/lantiq_gswip.h | 109 +++++++++++++++++++++++++++++++++
>  1 file changed, 109 insertions(+)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.h b/drivers/net/dsa/lantiq_gswip.h
> index fd898991180d..e8914480d59e 100644
> --- a/drivers/net/dsa/lantiq_gswip.h
> +++ b/drivers/net/dsa/lantiq_gswip.h
> @@ -224,6 +224,114 @@
>  
>  #define XRX200_GPHY_FW_ALIGN	(16 * 1024)
>  
> +#define GSW1XX_PORTS				6

a tricky questions for you ;-)

There are scarce references to Port 6 across GSW145 datasheet, the 7th port.
One could also enable/disable it (bit P6) in GSWIP_CFG (0xF400).

Yes, it's sold as 6-port switch, but the question is, shall the port 6 be
disabled to save power and avoid unnecessary EMI?

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com