Re: [PATCH v2 net-next 1/5] net: fec: use a member variable for maximum buffer size

[Andrew Lunn]

On Thu, Aug 21, 2025 at 01:33:32PM -0500, Shenwei Wang wrote:
> Refactor code to support Jumbo frame functionality by adding a member
> variable in the fec_enet_private structure to store PKT_MAXBUF_SIZE.

This is better, thanks.

> @@ -1145,9 +1145,12 @@ static void
>  fec_restart(struct net_device *ndev)
>  {
>  	struct fec_enet_private *fep = netdev_priv(ndev);
> -	u32 rcntl = OPT_FRAME_SIZE | FEC_RCR_MII;
> +	u32 rcntl = FEC_RCR_MII;
>  	u32 ecntl = FEC_ECR_ETHEREN;
>  
> +	if (fep->max_buf_size == OPT_FRAME_SIZE)
> +		rcntl |= (fep->max_buf_size << 16);

I was expecting something like s/OPT_FRAME_SIZE/fep->max_buf_size/g

This is introducing extra logic. I think the if (...) belongs in
another patch. The assignment is however what i expected.

    Andrew

---
pw-bot: cr