Re: [PATCH v6 3/3] arm64: dts: qcom: Add base HAMOA-IOT-EVK board

[Dmitry Baryshkov]

On Thu, Aug 21, 2025 at 04:20:24PM +0800, Yijie Yang wrote:
> The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of
> the Hamoa IoT SoM and a carrier board. Together, they form a complete
> embedded system capable of booting to UART.
> 
> This change enables the following peripherals on the carrier board:
> - UART
> - On-board regulators
> - USB Type-C mux
> - Pinctrl
> - Embedded USB (EUSB) repeaters
> - NVMe
> - pmic-glink
> - USB DisplayPorts
> - Bluetooth
> - Graphic
> - Audio

No WiFi?

> 
> Co-developed-by: Quill Qi <le.qi@xxxxxxxxxxxxxxxx> # Audio
> Signed-off-by: Quill Qi <le.qi@xxxxxxxxxxxxxxxx>
> Co-developed-by: Jie Zhang <quic_jiezh@xxxxxxxxxxx> # Graphic
> Signed-off-by: Jie Zhang <quic_jiezh@xxxxxxxxxxx>
> Co-developed-by: Shuai Zhang <quic_shuaz@xxxxxxxxxxx> # Bluetooth
> Signed-off-by: Shuai Zhang <quic_shuaz@xxxxxxxxxxx>
> Co-developed-by: Yongxing Mou <quic_yongmou@xxxxxxxxxxx> # USB DisplayPorts
> Signed-off-by: Yongxing Mou <quic_yongmou@xxxxxxxxxxx>
> Signed-off-by: Yijie Yang <yijie.yang@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/Makefile          |    1 +
>  arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 1247 ++++++++++++++++++++++++++++
>  2 files changed, 1248 insertions(+)
> 

> +
> +	vreg_edp_3p3: regulator-edp-3p3 {
> +		compatible = "regulator-fixed";
> +
> +		regulator-name = "VREG_EDP_3P3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +
> +		gpio = <&tlmm 70 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +
> +		pinctrl-0 = <&edp_reg_en>;
> +		pinctrl-names = "default";
> +
> +		regulator-always-on;

Why? If it supplies the panel, then the panel should be able to control
its power supplies.

> +		regulator-boot-on;
> +	};
> +
> +		wcd-playback-dai-link {
> +			link-name = "WCD Playback";
> +
> +			codec {
> +				sound-dai = <&wcd938x 0>, <&swr1 0>, <&lpass_rxmacro 0>;
> +			};
> +			cpu {

MIssing empty line between nodes.

> +				sound-dai = <&q6apmbedai RX_CODEC_DMA_RX_0>;
> +			};
> +
> +			platform {
> +				sound-dai = <&q6apm>;
> +			};
> +		};
> +

-- 
With best wishes
Dmitry