Re: [PATCH net v2] net: dlink: fix multicast stats being counted incorrectly

[Yeounsu Moon]

On Sat Aug 23, 2025 at 12:15 AM KST, Andrew Lunn wrote:
> The hash for fixes tends to be shorter than that.
>
> Fixes: 3401299a1b9e ("de6*/dl2k/sundance: Move the D-Link drivers")
>
> If you add this to your .git/config
>
> [pretty]
>         fixes = Fixes: %h (\"%s\")
>
> You can do
>
> git log --pretty=fixes 3401299a1b9e747cbf7de2cc0c8f6376c3cbe565
> Fixes: 3401299a1b9e ("de6*/dl2k/sundance: Move the D-Link drivers")
>
Thanks for pointing that out.


> This problem actually goes back further:
>
> git blame 3401299a1b9e~1 drivers/net/dl2k.c
>
> shows it was broken in the first commit in git.
>
> So the correct Fixes: tag is:
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>
Regarding the Fixes: tag, I have one question. You suggested
1da177e4c3f4 ("Linux-2.6.12-rc2"), which is indeed the first commit in
the current git history. However, the actual code change seems to go
back further, and I found it in the history.git repository.

In such cases, should the Fixes: tag refer to the first commit in the
mailine git tree, or to the actual commit in history.git where the bug
originated?