Re: [PATCH v2 2/3] dt-bindings: clock: exynos990: Reorder IDs clocks and extend

From: Krzysztof Kozlowski
Date: Sun Aug 24 2025 - 04:16:49 EST


On 23/08/2025 19:27, Denzeel Oliva wrote:
>> This looks like a massive ABI break, where is the justification for
>> doing it?
>>
>> Cheers,
>> Conor.
>
> Hi Conor,
>
> I reordered because the current IDs don’t match CMU_TOP:
> the PLL mux select is in PLL_CON0, not CON3, which gave wrong/low rates.


IDs are abstract, they cannot give wrong/low rates.

> I also added DPU/CMUREF and a missing fixed-factor path to stop bad rates
> and clk_summary hangs on hardware.


Not really related to ABI.

None of these justify changing the ABI or I don't understand the problem
at all.

Best regards,
Krzysztof