Re: [PATCH] mtd: spinand: add support for FudanMicro FM25S01A

[Tianling Shen]

Hello Miquel,

On 2025/8/24 23:46, Miquel Raynal wrote:
> Hello Tianling,
>
> On 10/08/2025 at 21:38:52 +08, Tianling Shen <cnsztl@xxxxxxxxx> wrote:
>
> > Add support for FudanMicro FM25S01A SPI NAND.
> > Datasheet: http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf
> >
> > Signed-off-by: Tianling Shen <cnsztl@xxxxxxxxx>
> > ---
> >   drivers/mtd/nand/spi/Makefile |  2 +-
> >   drivers/mtd/nand/spi/core.c   |  1 +
> >   drivers/mtd/nand/spi/fmsh.c   | 74 +++++++++++++++++++++++++++++++++++
> >   include/linux/mtd/spinand.h   |  1 +
> >   4 files changed, 77 insertions(+), 1 deletion(-)
> >   create mode 100644 drivers/mtd/nand/spi/fmsh.c
> >
> > diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
> > index 258da42451a4..e288742ea8f0 100644
> > --- a/drivers/mtd/nand/spi/Makefile
> > +++ b/drivers/mtd/nand/spi/Makefile
> > @@ -1,5 +1,5 @@
> >   # SPDX-License-Identifier: GPL-2.0
> > -spinand-objs := core.o otp.o
> > +spinand-objs := core.o fmsh.o otp.o
>
> You're adding a manufacturer driver in the middle of the core files. For
> now we kind of inforce an alphabetical order, so please move it below.

oops, sorry for that, I've sent v2 for it. Thank you!

Regards,
Tianling.

> >   spinand-objs += alliancememory.o ato.o esmt.o foresee.o gigadevice.o
> >   macronix.o
>
>                                                  ^
> Here
>
> >   spinand-objs += micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
> >   obj-$(CONFIG_MTD_SPI_NAND) += spinand.o
> > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> > index b0898990b2a5..ea47028d021a 100644
> > --- a/drivers/mtd/nand/spi/core.c
> > +++ b/drivers/mtd/nand/spi/core.c
> > @@ -1184,6 +1184,7 @@ static const struct spinand_manufacturer *spinand_manufacturers[] = {
> >   	&alliancememory_spinand_manufacturer,
> >   	&ato_spinand_manufacturer,
> >   	&esmt_c8_spinand_manufacturer,
> > +	&fmsh_spinand_manufacturer,
> >   	&foresee_spinand_manufacturer,
> >   	&gigadevice_spinand_manufacturer,
> >   	&macronix_spinand_manufacturer,
> > diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
> > new file mode 100644
> > index 000000000000..8b2097bfc771
> > --- /dev/null
> > +++ b/drivers/mtd/nand/spi/fmsh.c
>
> Otherise the driver is simple enough, so v2 should make it :)
>
> Thanks,
> Miquèl