RE: [PATCH] arm64: dts: toshiba: tmpv7708: Add default GIC address cells

[nobuhiro.iwamatsu.x90]

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Friday, August 22, 2025 10:34 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro.iwamatsu.x90@mail.toshiba>; Rob Herring <robh@xxxxxxxxxx>;
> Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Subject: [PATCH] arm64: dts: toshiba: tmpv7708: Add default GIC address cells
> 
> Add missing address-cells 0 to GIC interrupt node to silence W=1
> warning:
> 
>   tmpv7708.dtsi:503.4-507.28: Warning (interrupt_map):
> /soc/pcie@28400000:interrupt-map:
>     Missing property '#address-cells' in node
> /soc/interrupt-controller@24001000, using 0 as fallback
> 
> Value '0' is correct because:
> 1. GIC interrupt controller does not have children, 2. interrupt-map property (in
> PCI node) consists of five components and
>    the fourth component "parent unit address", which size is defined by
>    '#address-cells' of the node pointed to by the interrupt-parent
>    component, is not used (=0)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Thanks for your patch.

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>

Best regards,
  Nobuhiro