Re: [PATCH v2 0/3] crypto: hisilicon - add fallback function for hisilicon accelerater driver

[Herbert Xu]

On Mon, Aug 18, 2025 at 02:57:11PM +0800, Chenghai Huang wrote:
> Support fallback for zip/sec2/hpre when device is busy.
> 
> V1: https://lore.kernel.org/all/20250809070829.47204-1-huangchenghai2@xxxxxxxxxx/
> Updates:
> - Remove unnecessary callback completions.
> - Add CRYPTO_ALG_NEED_FALLBACK to hisi_zip's cra_flags.
> 
> Chenghai Huang (1):
>   crypto: hisilicon/zip - support fallback for zip
> 
> Qi Tao (1):
>   crypto: hisilicon/sec2 - support skcipher/aead fallback for hardware
>     queue unavailable
> 
> Weili Qian (1):
>   crypto: hisilicon/hpre - support the hpre algorithm fallback
> 
>  drivers/crypto/hisilicon/Kconfig            |   1 +
>  drivers/crypto/hisilicon/hpre/hpre_crypto.c | 314 +++++++++++++++++---
>  drivers/crypto/hisilicon/qm.c               |   4 +-
>  drivers/crypto/hisilicon/sec2/sec_crypto.c  |  62 +++-
>  drivers/crypto/hisilicon/zip/zip_crypto.c   |  52 +++-
>  5 files changed, 360 insertions(+), 73 deletions(-)

Are you mapping one hardware queue to a single tfm object?

Hardware queues should be shared between tfm objects.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt