Re: [PATCH 2/7] iio: adc: Remove dev_err_probe() if error is -ENOMEM
From: Jonathan Cameron
Date: Mon Aug 25 2025 - 04:40:49 EST
On Thu, 21 Aug 2025 22:31:51 +0200
Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> wrote:
> On Thu, Aug 21, 2025 at 10:07 AM Xichao Zhao <zhao.xichao@xxxxxxxx> wrote:
> >
> > The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> > Therefore, remove the useless call to dev_err_probe(), and just
> > return the value instead.
> >
> > Signed-off-by: Xichao Zhao <zhao.xichao@xxxxxxxx>
> > ---
> > drivers/iio/adc/hx711.c | 2 +-
> > drivers/iio/adc/imx93_adc.c | 3 +--
> > drivers/iio/adc/mcp3564.c | 2 +-
> > drivers/iio/adc/meson_saradc.c | 2 +-
> For meson_saradc:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>
Hi Martin (applies to others in this series),
For a comment about a tag please use the style submitting-patches suggests.
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> # for meson_saradc
Then the tooling picks it automatically. Sometimes I remember to edit commits
to tidy this up, but not always!
Jonathan