Re: [PATCH 6/6] gpio: gpio-ltc4283: Add support for the LTC4283 Swap Controller

From: Nuno Sá
Date: Mon Aug 25 2025 - 05:13:32 EST


On Tue, Aug 19, 2025 at 02:12:51PM +0200, Linus Walleij wrote:
> Hi Nuno,
>
> thanks for your patch!
>
> On Thu, Aug 14, 2025 at 12:52 PM Nuno Sá via B4 Relay
> <devnull+nuno.sa.analog.com@xxxxxxxxxx> wrote:
>
> > From: Nuno Sá <nuno.sa@xxxxxxxxxx>
> >
> > The LTC4283 device has up to 8 pins that can be configured as GPIOs.
> >
> > Note that PGIO pins are not set as GPIOs by default so if they are
> > configured to be used as GPIOs we need to make sure to initialize them
> > to a sane default. They are set as inputs by default.
> >
> > Signed-off-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
> (...)
>
> Can you check if you can use gpio-regmap.c helper?
>
> select GPIO_REGMAP
>
> git grep devm_gpio_regmap_register
> for example drivers using this.
>
> I think it can further cut down the code to very little.

Sure, I'll have that in mind for v2.

- Nuno Sá

>
> Yours,
> Linus Walleij