Re: [PATCH net v2] phy: mscc: Fix when PTP clock is register and unregister

[Vladimir Oltean]

On Mon, Aug 25, 2025 at 08:55:43AM +0200, Horatiu Vultur wrote:
> It looks like that every time when the interface was set down and up the
> driver was creating a new ptp clock. On top of this the function
> ptp_clock_unregister was never called.
> Therefore fix this by calling ptp_clock_register and initialize the
> mii_ts struct inside the probe function and call ptp_clock_unregister when
> driver is removed.
> 
> Fixes: 7d272e63e0979d ("net: phy: mscc: timestamping and PHC support")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
> 
> ---
> v1->v2:
> - move implementation of __vsc8584_deinit_ptp into vsc8584_ptp_deinit
> - drop the PHY matching and check if ptp_clock is valid.
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>