Re: [PATCH] net: mdiobus: Move all reset registration to `mdiobus_register_reset()`
From: Russell King (Oracle)
Date: Mon Aug 25 2025 - 10:17:27 EST
On Mon, Aug 25, 2025 at 04:09:34PM +0200, Bence Csókás wrote:
> Make `mdiobus_register_reset()` function handle both gpiod and
> reset-controller-based reset registration.
The commit description should include not only _what_ is being done but
also _why_.
Here's from Documentation/process/submitting-patches.rst:
Describe your problem. Whether your patch is a one-line bug fix or
5000 lines of a new feature, there must be an underlying problem that
motivated you to do this work. Convince the reviewer that there is a
problem worth fixing and that it makes sense for them to read past the
first paragraph.
Just describing _what_ is being done doesn't do anything to convince
a reviewer that the patch is worth applying.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!