Re: [PATCH v4 6/6] auxdisplay: TM16xx: Add support for SPI-based controllers

From: Andy Shevchenko
Date: Mon Aug 25 2025 - 11:21:36 EST


On Sun, Aug 24, 2025 at 11:32:32PM -0400, Jean-François Lessard wrote:
> Add support for TM16xx-compatible auxiliary display controllers connected
> via the SPI bus.
>
> The implementation includes:
> - SPI driver registration and initialization
> - Probe/remove logic for SPI devices
> - Controller-specific handling and communication sequences
> - Integration with the TM16xx core driver for common functionality
>
> This allows platforms using TM16xx or compatible controllers over SPI to be
> managed by the TM16xx driver infrastructure.
>
> Signed-off-by: Jean-François Lessard <jefflessard3@xxxxxxxxx>
> ---

> Notes:
> include <linux/of.h> is required for of_match_ptr

Yeah, please drop the latter and remove the former.

All other comments are the same as per I²C counterpart of the driver.

--
With Best Regards,
Andy Shevchenko