Re: [PATCH v3 05/12] man/man2/fspick.2: document "new" mount API
From: Askar Safin
Date: Mon Aug 25 2025 - 12:23:38 EST
---- On Fri, 22 Aug 2025 17:40:18 +0400 Aleksa Sarai <cyphar@xxxxxxxxxx> wrote ---
> On 2025-08-22, Askar Safin <safinaskar@xxxxxxxxxxxx> wrote:
> > ---- On Sat, 09 Aug 2025 00:39:49 +0400 Aleksa Sarai <cyphar@xxxxxxxxxx> wrote ---
> > > +The above procedure is functionally equivalent to
> > > +the following mount operation using
> > > +.BR mount (2):
> >
> > This is not true.
> >
> > fspick adds options to superblock. It doesn't remove existing ones.
>
> fspick "copies the existing parameters" would be more accurate. I can
> reword this, but it's an example and I don't think it makes sense to add
> a large amount of clarifying text for each example.
I suggest adding "but mount(2) clears existing parameters here, and fspick/fsconfig doesn't".
--
Askar Safin
https://types.pl/@safinaskar