Re: [PATCH net v1] Fixes: xircom auto-negoation timer

[Alex Tran]

> > You state this is a fix. Which problem does it fix?
The change was originally suggested under a FIXME comment but it seems
like more of a cleanup.

> > Do you have this hardware for testing your patches?
I do not have the physical hardware. The change was made based on code
analysis and successful kselftests and kernel compilation on all yes
config.

> > You might consider migrating this driver to use phylib.
> > Provided this contributes to reducing complexity.
>
> There is plenty to reduce. There is a full bit-banging MDIO
> implementation which could be replaced with the core implementation.
>
> The harder part for converting to phylib will be the ML6692 and
> DP83840A. There are no Linux driver for these, but given the age,
> there is a good chance genphy will work.

Migrating the driver to use phylib sounds like a good idea. I can
rework this patch and send in a v2 with the changes if you all are
fine with moving forward with this.



-- 
Alex Tran