[PATCH v2 1/2] dt-bindings: interconnect: qcom: make sc7280 aggre{1,2}-noc clocks optional
From: Brian Norris
Date: Mon Aug 25 2025 - 18:58:09 EST
We've found that some device firmware does not expose all the QoS
resources necessary to manage these interconnects, and that the driver
code that starts using them crashes. Leave 'clocks' as optional for
qcom,sc7280-aggre1-noc and qcom,sc7280-aggre2-noc instead.
Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
---
Changes in v2:
* new in v2
.../interconnect/qcom,sc7280-rpmh.yaml | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml
index 81c3dff53992..5dbd0563ac17 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml
@@ -82,17 +82,17 @@ allOf:
items:
- description: RPMH CC IPA clock
+ # QoS clocks are only valid for aggre{1,2}-noc. Some TZ firmware do not
+ # expose even these, so they remain optional.
- if:
- properties:
- compatible:
- contains:
- enum:
- - qcom,sc7280-aggre1-noc
- - qcom,sc7280-aggre2-noc
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sc7280-aggre1-noc
+ - qcom,sc7280-aggre2-noc
then:
- required:
- - clocks
- else:
properties:
clocks: false
--
2.51.0.261.g7ce5a0a67e-goog