Re: [PATCH v4 1/2] iio: magnetometer: add support for Infineon TLV493D 3D Magentic sensor

[Dixit Parmar]

> > > > > > >  st_magn-$(CONFIG_IIO_BUFFER) += st_magn_buffer.o
> > > > > > >  obj-$(CONFIG_IIO_ST_MAGN_I2C_3AXIS) += st_magn_i2c.o
> > > > > > >  obj-$(CONFIG_IIO_ST_MAGN_SPI_3AXIS) += st_magn_spi.o
> > > > > > >
> > > > > > > +obj-$(CONFIG_INFINEON_TLV493D)             += tlv493d.o
> > > > > > > +
> > > > > > >  obj-$(CONFIG_SENSORS_HMC5843)              += hmc5843_core.o
> > > > > > >  obj-$(CONFIG_SENSORS_HMC5843_I2C)  += hmc5843_i2c.o
> > > > > > >  obj-$(CONFIG_SENSORS_HMC5843_SPI)  += hmc5843_spi.o
> > > > > >
> > > > > > I haven't got the ordering rules here and in Kconfig. Can it be alphabetical?
> > > > > From what I can see, the order is alphabetical based on the CONFIG option in the
> > > > > Makefile and Kconfig, and I kept CONFIG_INFINEO_TLV493D after CONFIG_IIO_ST*.
> > > > > Isn't it in correct order? or my understanding is incorrect?
> > > >
> > > > I dunno, The file name there is with the vendor prefix, in many cases
> > > > the configuration option is with vendor prefix as well, but the file.
> > > Hi Jonathan, Can you please suggest best possible way here?
> > Hi Jonathan, When you get a chance, please share your thoughts on this.
>
> No hard rules on this.  We should probably make some but don't have
> them yet, so try to go with what seems most common in the particular file.
>
> Jonathan
Okay. I believe we are good considering most of the drivers are having
vendor prefix,
so does this driver too, and its currently in correct alphabetical
order. Considering
the alphabetical order followed is for CONFIG options.
Thanks,
Dixit