Re: [PATCH RFC 4/7] md/raid10: convert read/write to use bio_submit_split()

From: Christoph Hellwig
Date: Tue Aug 26 2025 - 03:55:48 EST


On Tue, Aug 26, 2025 at 09:13:41AM +0800, Yu Kuai wrote:
> > The NULL return should only happen for REQ_NOWAIT here, so maybe
> > give R10BIO_Returned a more descriptive name? Also please document
> > the flag in the header.
>
> And also atomic write here, if bio has to split due to badblocks here.
> The flag is refer to raid1. I can add cocument for both raid1 and raid10
> in this case.

Umm, that's actually a red flag. If a device guarantees atomic behavior
it can't just fail it. So I think REQ_ATOMIC should be disallowed
for md raid with bad block tracking.

>