[PATCH 1/4] staging: media: atomisp: Remove unnecessary forward declarations

From: Adrian Barnaś
Date: Tue Aug 26 2025 - 06:44:31 EST


Get rid of fifo_monitor_status_valid() and fifo_monitor_status_accept()
forward declaration because it brings no value.

Signed-off-by: Adrian Barnaś <abarnas@xxxxxxxxxx>
---
.../hive_isp_css_common/host/fifo_monitor.c | 44 +++++++------------
1 file changed, 16 insertions(+), 28 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/fifo_monitor.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/fifo_monitor.c
index f0de788154560..c5f78c5cf04c6 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/fifo_monitor.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/fifo_monitor.c
@@ -31,15 +31,23 @@ STORAGE_CLASS_FIFO_MONITOR_DATA unsigned int FIFO_SWITCH_ADDR[N_FIFO_SWITCH] = {
#include "fifo_monitor_private.h"
#endif /* __INLINE_FIFO_MONITOR__ */

-static inline bool fifo_monitor_status_valid(
- const fifo_monitor_ID_t ID,
- const unsigned int reg,
- const unsigned int port_id);
+static inline bool fifo_monitor_status_valid(const fifo_monitor_ID_t ID,
+ const unsigned int reg,
+ const unsigned int port_id)
+{
+ hrt_data data = fifo_monitor_reg_load(ID, reg);

-static inline bool fifo_monitor_status_accept(
- const fifo_monitor_ID_t ID,
- const unsigned int reg,
- const unsigned int port_id);
+ return (data >> (((port_id * 2) + _hive_str_mon_valid_offset))) & 0x1;
+}
+
+static inline bool fifo_monitor_status_accept(const fifo_monitor_ID_t ID,
+ const unsigned int reg,
+ const unsigned int port_id)
+{
+ hrt_data data = fifo_monitor_reg_load(ID, reg);
+
+ return (data >> (((port_id * 2) + _hive_str_mon_accept_offset))) & 0x1;
+}

void fifo_channel_get_state(
const fifo_monitor_ID_t ID,
@@ -539,23 +547,3 @@ void fifo_monitor_get_state(
}
return;
}
-
-static inline bool fifo_monitor_status_valid(
- const fifo_monitor_ID_t ID,
- const unsigned int reg,
- const unsigned int port_id)
-{
- hrt_data data = fifo_monitor_reg_load(ID, reg);
-
- return (data >> (((port_id * 2) + _hive_str_mon_valid_offset))) & 0x1;
-}
-
-static inline bool fifo_monitor_status_accept(
- const fifo_monitor_ID_t ID,
- const unsigned int reg,
- const unsigned int port_id)
-{
- hrt_data data = fifo_monitor_reg_load(ID, reg);
-
- return (data >> (((port_id * 2) + _hive_str_mon_accept_offset))) & 0x1;
-}
--
2.51.0.261.g7ce5a0a67e-goog