Re: [PATCH v2] staging: gpib: use int type to store negative error codes
From: Dan Carpenter
Date: Tue Aug 26 2025 - 08:36:36 EST
On Tue, Aug 26, 2025 at 08:32:01PM +0800, Qianfeng Rong wrote:
> The "ret" variable is used to store the return from bb_write() returns
> either zero on success or negative error codes on failure. Storing the
> error codes in size_t which is an unsigned long, doesn't cause an issue
> at runtime but it's ugly as pants. Change "ret" from size_t to int
> type. No effect on runtime.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@xxxxxxxx>
> ---
> v2: Modified commit message as suggested by Dan.
Awesome. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
regards,
dan carpenter