Re: [PATCH v3 2/2] rust: time: Implement basic arithmetic operations for Delta

[FUJITA Tomonori]

On Wed, 20 Aug 2025 16:26:44 -0400
Lyude Paul <lyude@xxxxxxxxxx> wrote:

> While rvkms is only going to be using a few of these, since Deltas are
> basically the same as i64 it's easy enough to just implement all of the
> basic arithmetic operations for Delta types.
> 
> Keep in mind there's one quirk here - the kernel has no support for
> i64 % i64 on 32 bit platforms, the closest we have is i64 % i32 through
> div_s64_rem(). So, instead of implementing ops::Rem or ops::RemAssign we
> simply provide Delta::rem_nanos().
> 
> Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx>

Reviewed-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxx>